Skip to content

Conversation

@nehanene15
Copy link
Collaborator

Description of changes

Revert change, which caused no columns to be picked up:
packages/ibis/expr/types/relations.py", line 1724, in select\n raise com.IbisTypeError(\nibis.common.exceptions.IbisTypeError: You must select at least one column for a valid projection\n'.

Also test updating to 'redshift' dialect since customer is getting NoSuchTable error due to internal catalog searching for PG metadata tables.

Checklist

  • I have followed the CONTRIBUTING Guide.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated any relevant documentation to reflect my changes, if applicable
  • I have added unit and/or integration tests relevant to my change as needed
  • I have already checked locally that all unit tests and linting are passing (use the tests/local_check.sh script)
  • I have manually executed end-to-end testing (E2E) with the affected databases/engines

@nehanene15
Copy link
Collaborator Author

/gcbrun

@nehanene15 nehanene15 requested a review from nj1973 January 26, 2026 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants